multilingual SubjectIndex backed by CSV file#608
Merged
Conversation
1e8b6a0 to
53343bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 99.55% 99.58% +0.03%
==========================================
Files 86 87 +1
Lines 5663 5834 +171
==========================================
+ Hits 5638 5810 +172
+ Misses 25 24 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
SonarCloud Quality Gate failed.
|
juhoinkinen
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes (hopefully) the switch to multilingual vocabularies (#559) started in PR #600 and continued in PRs #604 and #606. It changes the SubjectIndex so that it keeps track of labels in all available languages, not just one at a time. The index is stored on disk in a CSV file which stores the labels in different columns named e.g.
label_en,label_fi,label_svetc. It replaces the current short-lived format where separate TSV files for each language were used (subjects.en.tsv,subjects.fi.tsvetc.). It turned out to be easier and cleaner to have just a single file containing labels in all languages. CSV is a good format for this as the columns can be named in a header row, so there is some flexibility in which columns are used.It is also possible to use this CSV format to represent multilingual vocabularies that can be loaded with the
annif loadvoccommand.