Move geocode functions from WEX to SAM#160
Merged
Merged
Conversation
Remove geocoding functions `GeoCodeGoogle()` and `GeoCodeDeveloper()` from WEX and move them to SAM: * Allows API keys to be defined in SAM consistent with other API calls * Allows URLs for API calls to be stored in webapis.conf file instead of hard-coded. Remove SetApiKeys() function, which is only required to make geocoding API keys available in WEX. Move LK `geocode()` function to SAM so it can use SAM API keys. This means it is no longer available in LK for SDKtool. (Programmers should write their own code with `curl()` to the geocoding service of their choice.)
14 tasks
sjanzou
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with NatLabRockies/SAM#1380
Remove geocoding functions
GeoCodeGoogle()andGeoCodeDeveloper()from WEX:Allows API keys to be defined in SAM consistent with other API calls
Allows URLs for API calls to be stored in webapis.conf file instead of hard-coded.
Remove
SetApiKeys()function, which is only required to make geocoding API keys available in WEX.Move LK
geocode()function to SAM so it can use SAM API keys.