Add support for WIND Toolkit CSV file formats#984
Closed
cpaulgilman wants to merge 10 commits into
Closed
Conversation
SRW format description at https://samrepo.nrelcloud.org/help/weather_format_srw_wind.htm
In some cases, WIND Toolkit API returns files with "N/A" in columns. This fix avoids throwing an stof() error and allows the data to be read.
This reverts commit d58b63a.
Collaborator
Author
|
Replace with #985 to try to fix CI build errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NatLabRockies/SAM#962
Also partially addresses NatLabRockies/SAM#815 by adding support for CSV files downloaded from RE Explorer
Next step is to update wind data download widget in SAM UI to download from wtk-download instead of wtk-srw-download, and possibly other WIND Toolkit endpoints at https://developer.nrel.gov/docs/wind/wind-toolkit/ (note that not all endpoints use the same CSV file format).
For endpoints that use different file format, consider writing a macro to convert files. For example, compare files from offshore-mid-atlantic-download to wtk-download.
SAM should now work with any of the wind data files here:
wind-file-samples.zip
To test, run test-wind-files.lk script included in .zip archive.
Should also spot check other wind data files in both WIND Toolkit CSV format and SRW format.
This requires a new Help topic describing WIND Toolkit CSV format.