Skip to content

Ssc 923 use prod factors#925

Merged
brtietz merged 6 commits into
developfrom
ssc_923_use_prod_factors
Nov 3, 2022
Merged

Ssc 923 use prod factors#925
brtietz merged 6 commits into
developfrom
ssc_923_use_prod_factors

Conversation

@brtietz

@brtietz brtietz commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator

Use production factors from the actual system instead of lat/lon when getting size and dispatch from REopt. Additional required changes in SAM PR: NatLabRockies/SAM#1165 Fixes #923

Steps to test:

  1. Run the attached SAM and weather files in 2021.12.02:
    2018_weather_file_dispatch.zip
  2. Build SAM from this branch and the SAM branch sam_1092_update_reopt_script
  3. See improved sizing and dispatch (via improved NPV) on branches

@dguittet dguittet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do a check if gen exists before adding the prod timeseries? I'm pretty sure the way it's run in the GUI calls simulate on the system first so gen should definitely exist, but technically this equation doesn't require simulate to be called beforehand.

@brtietz

brtietz commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator Author

can you do a check if gen exists before adding the prod timeseries? I'm pretty sure the way it's run in the GUI calls simulate on the system first so gen should definitely exist, but technically this equation doesn't require simulate to be called beforehand.

Good thinking. What should the code do if gen doesn't exist? Throw an error, or revert to the lat/lon behavior? If the latter, is there a good losses assumption?

@dguittet

dguittet commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

Yes I think using the lat/lon, which basically has REopt call PVWatts. Could losses be an optional input?

@brtietz brtietz merged commit 7f68a61 into develop Nov 3, 2022
@brtietz brtietz deleted the ssc_923_use_prod_factors branch November 18, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert size battery and dispatch REopt call to use prod_factor_series_kw

2 participants