Skip to content

Ssc 599 negative cleared capacity#826

Merged
brtietz merged 7 commits into
patchfrom
ssc_599_negative_cleared_capacity
May 31, 2022
Merged

Ssc 599 negative cleared capacity#826
brtietz merged 7 commits into
patchfrom
ssc_599_negative_cleared_capacity

Conversation

@brtietz

@brtietz brtietz commented May 27, 2022

Copy link
Copy Markdown
Collaborator

Improve handling of cleared capacity throughout merchant plant code, and some bugfixes for the battery time series prices.

  • Only use positive revenue values in revenue row of cashflow table, to match other financial models
  • Negative values of revenue are now assigned to cf_utility_bill, with new consumed_cost outputs
    • Note that the previous code had a copy-paste error vs the other financial models, and was off by a factor of 1000 for a kW to MW conversion, hence the large increase in NPV in the two unit tests.
  • common.cpp now plays more nicely with cleared capacity as a percent of generation, so that dispatch is the same between single owner and merchant plant.
  • Users get a warning (not an error) if the negative cleared capacities don't match generation

The result is that given the same price series for one year, merchant plant and single owner now (once again?) produce the same financial results. Test file here:
aligned price series.zip

Differences in the "all markets" case are worth some debate, but I worried they'll be late for the patch, so I created another issue here: #825

@brtietz brtietz added this to the 2021.12.02 Patch 2 milestone May 27, 2022

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that the SO and merchant plant results are aligning!

Two issues:

  1. "capacity_factor_sales" is missing from results in Summary tab in SAM, e.g.

image

  1. The default results have changed significantly for SAM - please review ssc_599_negative_cleared_capacity branch of SAM and pull request NatLabRockies/SAM#1058

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Looks good to me aside from the missing capacity_factor_sales issue Steve raised.

@brtietz

brtietz commented May 31, 2022

Copy link
Copy Markdown
Collaborator Author

capacity_factor_sales shows up now that #819 has been merged into patch.

@sjanzou Thanks for re-running the defaults! The prior LCOEs were overestimating the cost of grid energy by a factor of 1000 (missed kWh to MWh conversion) so the large decreases are expected.

@brtietz brtietz requested a review from sjanzou May 31, 2022 16:47
@brtietz brtietz merged commit 0e0330c into patch May 31, 2022
@brtietz brtietz deleted the ssc_599_negative_cleared_capacity branch November 18, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants