Conversation
cmod_merchant_plant_eqns updated to handle single value inputs extrapolate_timeseries updated to handle single value array input
brtietz
requested changes
May 26, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Fix works well for a single value, but annual, monthly, and weekly all appear to be broken (no revenue with price set to $10/MWh and 100% cleared capacity). I've updated the test file with those additional cases:
merchant-single-value-bug.zip
Collaborator
Author
|
All modes fixed nd tested for all merchant plant revenue streams. Test project files with 25 year and 2 year analysis period with one and all 5 merchant plant revenue streams enabled |
brtietz
approved these changes
May 27, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Works great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmod_merchant_plant_eqns updated to handle single value inputs
extrapolate_timeseries updated to handle single value array input