Fix cash flow issues#818
Merged
Merged
Conversation
brtietz
approved these changes
May 18, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for explaining why you commented out code! SSC changes look good, some issues with the SAM half of this PR.
|
|
||
| // dispatch | ||
| std::vector<double> ppa_cf; | ||
| /* Community solar not available with storage, need to address price signal dispatch with no PPA if we enable with storage |
Collaborator
There was a problem hiding this comment.
First we would need to decide whether or not we were including load.
We could always choose to disable the battery options that require prices. With load that would be peak shaving/grid power targets, custom and manual. Without load that would be pv smoothing, manual, and custom.
sjanzou
approved these changes
May 19, 2022
mjprilliman
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with NatLabRockies/SAM#1044
Community Solar:
Fix receivables reserve to calculate based on subscriber payment revenue instead of PPA revenue (PPA revenue not available for community solar).
Comment out PPA-related output variables to avoid outputs with null values.
Sale Leaseback: