Change "resiliency" variable labels for clariity#739
Merged
Conversation
The term "resiliency" means different things in different contexts, so avoid using in labels. In this case use "Battery hours of autonomy during grid outage" instead.
7 tasks
brtietz
requested changes
Jan 28, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Overall I like the naming and the grouping - just one nitpick regarding min and max in the variable names (which might trigger some additional renaming)
sjanzou
approved these changes
Jan 29, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good... I agree we should, at some point, have a consistent max and min naming scheme
dguittet
approved these changes
Jan 31, 2022
brtietz
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term "resiliency" means different things in different contexts, so avoid using in labels. In this case use "Battery hours of autonomy during grid outage" instead.
Accompanies NatLabRockies/SAM#902
Replacing "resiliency" in variable labels with "hours of battery autonomy during grid outage".
I did not change the "resiliency" group name to avoid problems with PySAM.
Alternate suggestions for variable labels welcome!