Ssc 379 ancillary losses#458
Merged
Merged
Conversation
added 4 commits
October 1, 2020 11:35
Closed
added 2 commits
October 21, 2020 09:35
…de FOM code to new efficiency calcs
dguittet
requested changes
Oct 23, 2020
dguittet
left a comment
Collaborator
There was a problem hiding this comment.
Really great job on a confusing issue. Thanks for all the tests. I think the logic is sound, though I had some questions about dispatching in the comments.
Please also update the var_info table to specify that the number of entries acceptable for the loss schedule is 1 or same as weather file.
added 8 commits
October 23, 2020 16:19
…cillary_losses
…ecting dispatch to assign loss types
…cillary_losses
…ove labels for loss values, clean up variable initalization in powerflow, simplify boolean for PV loss powerflow
…, add test showing changed dispatch. Actual dispatch appears to be current limited
…cillary_losses
…cillary_losses
dguittet
approved these changes
Oct 30, 2020
dguittet
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the changes! This looks great! Just one more documentation related thing, could you add a comment in battery_t and/or powerflow to explain which losses are covered by which.
added 2 commits
October 30, 2020 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #379. Connects battery's loss model to powerflow via a line in dispatch_t::runDispatch. Losses are covered by:
Losses are applied on the AC side for AC connected batteries, and on the DC side for DC connected batteries. AC batteries will not cover the losses from PV unless they can charge from PV, but DC batteries will always cover the charging/idle losses from PV if PV is being exported to load/the grid.
Automated and custom dispatch have new code that accounts for losses. Front of meter automatic, behind the meter automatic, and manual dispatch all now have tests with losses.