Skip to content

Make Albedo Message Great Again#1385

Merged
cpaulgilman merged 2 commits into
developfrom
sam-2172-albedo-error
Apr 13, 2026
Merged

Make Albedo Message Great Again#1385
cpaulgilman merged 2 commits into
developfrom
sam-2172-albedo-error

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Improve error messages for Detailed PV and PVWatts when albedo data in weather file is invalid.

Fixes NatLabRockies/SAM#2172

To Test

  1. Run a Detailed PV and PVWatts case with this weather file with bad albedo data for testing: Kotzebue_AK_66.8967_-162.586_nsrdb-polar-tmy-v4-0-0_60_tmy.zip

  2. Click Notices on Results page to review error messages.

Corresponding branches and PRs:

None

Unit Test Impact:

None

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

@cpaulgilman cpaulgilman added this to the SAM 2026 Release milestone Apr 10, 2026
@cpaulgilman cpaulgilman requested a review from mjprilliman April 10, 2026 22:28
@cpaulgilman cpaulgilman self-assigned this Apr 10, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 24266733150

Coverage increased (+0.01%) to 56.298%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 149 coverage regressions across 5 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

149 previously-covered lines in 5 files lost coverage.

File Lines Losing Coverage Coverage
ssc/shared/lib_pv_io_manager.cpp 88 83.95%
ssc/ssc/cmod_pvwattsv8.cpp 36 82.83%
or-tools-9.14/install_release/include/eigen3/Eigen/src/Core/util/Memory.h 13 48.2%
ssc/shared/lib_battery.cpp 7 89.8%
ssc/shared/lib_geothermal.cpp 5 65.99%

Coverage Stats

Coverage Status
Relevant Lines: 121119
Covered Lines: 68187
Line Coverage: 56.3%
Coverage Strength: 3479197.73 hits per line

💛 - Coveralls

@cpaulgilman cpaulgilman merged commit e4de09c into develop Apr 13, 2026
8 checks passed
@cpaulgilman cpaulgilman deleted the sam-2172-albedo-error branch April 13, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing Albedo Error Messages

3 participants