Skip to content

Remove wind file elevation check#1317

Merged
sjanzou merged 2 commits into
developfrom
sam-2019-windfile-elevation
Apr 17, 2025
Merged

Remove wind file elevation check#1317
sjanzou merged 2 commits into
developfrom
sam-2019-windfile-elevation

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Set elevation to zero if not in wind file

Fixes NatLabRockies/SAM#2019

Set elevation to zero if not in wind file
@cpaulgilman cpaulgilman added the dev bug Internal bug that should not be included in release notes label Apr 16, 2025
@cpaulgilman cpaulgilman added this to the SAM Spring 2025 Release milestone Apr 16, 2025
@cpaulgilman cpaulgilman requested a review from sjanzou April 16, 2025 21:04
@cpaulgilman cpaulgilman self-assigned this Apr 16, 2025
@coveralls

coveralls commented Apr 16, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14509325817

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.706%

Totals Coverage Status
Change from base Build 14505194655: 0.0%
Covered Lines: 64318
Relevant Lines: 117570

💛 - Coveralls

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and downloads are working

current release fails
image

this pull request branch works
image

@sjanzou sjanzou merged commit bf81615 into develop Apr 17, 2025
@sjanzou sjanzou deleted the sam-2019-windfile-elevation branch April 17, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev bug Internal bug that should not be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wind file reader requires data not used by wind power model.

3 participants