Throw error whenever cumulative energy exceeds maximum tier usage for a given period.#1304
Conversation
Pull Request Test Coverage Report for Build 14103495681Details
💛 - Coveralls |
brtietz
approved these changes
Mar 27, 2025
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
This works well! I additionally tested a two tiered rate to make sure it still worked, and I got the expected errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed SAM issue NatLabRockies/SAM#1834
Throws error message rather than producing erroneous results.
To test follow the steps:
Load a behind the meter model
Set the compensation for distributed generation to net billing
Set a maximum tier to 100 kWh (or something lower than the month's usage
Run simulation
The bill savings are negative
The following file can be used to test a valid case and a case with an invalid maximum usage for the maximum tier.
SAM_1834.zip