Improve error handling for forecast price signals object#1288
Conversation
The changes look good... Could you please provide the pysam test script? Thanks! |
|
Please download: BatteryMerchantPlantPricingTest.zip for a PySAM script that causes the error. In PySAM 6.0.1 this crashes with no output. On this branch it should produce an error about matrix dimensions. Note that the MerchantPlant can use the inputs in this format, so I'm open to an alternative solution that brings those matrix transformations to bear (but think this error handling code is helpful regardless) |
sjanzou
left a comment
There was a problem hiding this comment.
Agreed, the message is much better than the no message before ;-)
Should the BatteryMerchantPlantPricingTest.py (or something to trigger the message) be added to the pysam tests? Should this be tied or referenced to the pysam repo?
| } | ||
|
|
||
| /// Test standalone battery compute modeule with a input lifetime generation and merchant plant prices | ||
| TEST_F(CMBattery_cmod_battery_fom, MerchantPlantLifetimeAutomatic) { |
There was a problem hiding this comment.
Was lifetime model crucial to the case being fixed here?
There was a problem hiding this comment.
If so, can it be set to 2 instead of 25? For shorter tests
There was a problem hiding this comment.
Good call. I converted the test to a single year.
Handle previously unhanded error reports from the forecast price signal object. Now throws an exec error instead of crashing.
This is not testable with the GUI, only SDK, PySAM, or gtest. I can provide PySAM code to reproduce if desired, otherwise the new tests are likely sufficient.