Update REopt API#1187
Merged
Merged
Conversation
* Fixes issue with large number inputs like 1e38 for electricity rate tier limits.
per NatLabRockies/SAM#1742 Also add comment to recent change to solver_name
sjanzou
approved these changes
Jul 24, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good... the Windows runners seem to have intermittent issues with the test results. I restarted the failed job.
|
|
||
| reopt_settings.assign_match_case("time_steps_per_hour", var_data((int)(sim_len / 8760))); | ||
| reopt_settings.assign("solver_name", var_data("SCIP")); // "HiGHS" option does not work with large numbers like 1e38 for tier max values per https://github.com/NREL/SAM/issues/1742 | ||
|
|
Collaborator
There was a problem hiding this comment.
interesting to note for OR tools inclusion in ssc for the Fall release!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NatLabRockies/SAM#1742
net_metering_limit_kwto system capacity when net metering is enabled.max_kwinstead of bothexisting_kwandmax_kw.To test:
Build a) SAM-private or b) SAM open source with NREL developer key and email in private.h.
Create a default PV Battery / Residential and PV Battery / Commercial case and click Get size and dispatch on Battery Cell and System page. REopt should return non-zero battery size and dispatch array.
Note that REopt API call and optimization takes a while -- I'm not sure if the SCIP solver is slower than HiGHS. This is something we may want to investigate for the Fall 2024 release.