Skip to content

Add dt_hr options#1173

Merged
dguittet merged 2 commits into
patchfrom
batt_state
Jun 25, 2024
Merged

Add dt_hr options#1173
dguittet merged 2 commits into
patchfrom
batt_state

Conversation

@dguittet

@dguittet dguittet commented Jun 5, 2024

Copy link
Copy Markdown
Collaborator

fixes #1172

@dguittet dguittet requested a review from brtietz June 18, 2024 16:15

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some documentation as to why a user would want to call this instead of ChangeTimestep? Is this just to reduce function calls?

@dguittet

Copy link
Copy Markdown
Collaborator Author

@brtietz Added, let me know if that comment doesn't explain it

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment!

@dguittet dguittet merged commit e257950 into patch Jun 25, 2024
@dguittet dguittet deleted the batt_state branch June 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BatteryStateful set_state allow dt_hr input

2 participants