Distribution clipping method#1137
Conversation
checks for divide by zero error
janinefreeman
left a comment
There was a problem hiding this comment.
Great implementation of a complex model! Some comments in-line that should be addressed before merging.
| p_subhourlyClippingLossFactor = cm->allocate("subhourly_clipping_loss_factor", numberOfLifetimeRecords); | ||
| //p_subhourlyClippingLossFactor = cm->allocate("subhourly_clipping_loss_factor", numberOfLifetimeRecords); | ||
|
|
||
| p_DistributionClippingLoss = cm->allocate("distribution_clipping_loss", numberOfLifetimeRecords); |
There was a problem hiding this comment.
Should this output, and the subhourly clipping loss above, be conditionally defined to only show up if these features are enabled?
There was a problem hiding this comment.
Should the total loss and percentage outputs be conditional in the outputs as well?
There was a problem hiding this comment.
We currently have bifacial electrical mismatch show up as a potential modeled loss factor that shows up in all model runs just as a data point.
There was a problem hiding this comment.
Ah. I am always in favor of outputs only showing up when they apply, but I'm sure there are a variety that have gone unnoticed.
There was a problem hiding this comment.
No worries I can make those conditional.
-Implement Walker clipping method that uses distribution of PV power output to calculate clipping potential
-https://www.nrel.gov/docs/fy20osti/76859.pdf
-Accessible through SDK
-Add test for feature usage
-Linke turbidity currently fixed at 1.0, todo add surrogate or lookup for turbidity value