Skip to content

Address confusion and consistency in powerflow variables#1132

Merged
brtietz merged 1 commit into
patchfrom
sam_1684_consistent_tolerances
Feb 22, 2024
Merged

Address confusion and consistency in powerflow variables#1132
brtietz merged 1 commit into
patchfrom
sam_1684_consistent_tolerances

Conversation

@brtietz

@brtietz brtietz commented Feb 19, 2024

Copy link
Copy Markdown
Collaborator
  • Use same tolerance in powerflow code and utility rate code, which both generate "electricity from grid to x varaibles"
  • Rename gen_purchases so it's clear that it does not include load it btm models

Fixes NatLabRockies/SAM#1684, see the issue for test file.

@brtietz brtietz added this to the 2023 Release Patch 1 milestone Feb 19, 2024
@brtietz brtietz self-assigned this Feb 19, 2024

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with files from NatLabRockies/SAM#1684

image

@brtietz brtietz merged commit 3041e7c into patch Feb 22, 2024
@brtietz brtietz deleted the sam_1684_consistent_tolerances branch February 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detailed PV and PV-Battery hourly and hourly lifetime discrepancy

3 participants