fix adjustment factor use for pvwatts#1113
Merged
Merged
Conversation
Collaborator
|
Nice catch! This issue is probably more widespread than just pvwatts right? Did you try something similar with pvsamv1 for example? |
Collaborator
Author
|
@mjprilliman I modified (locally) the notebook to use pvsamv1 and didn't run into the same project with adjustment factors zeroing out AC, so they must be handled differently in some way... |
Collaborator
|
See my comment on #1111 - I don't think this fixes the root cause of the issue |
Collaborator
|
Do we need to do anything here for Patch 1? |
janinefreeman
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1111