Skip to content

Solve crash in retail rates dispatch SAM 1629#1100

Merged
brtietz merged 4 commits into
developfrom
sam_1629_improve_retail_rates_error_handling
Dec 6, 2023
Merged

Solve crash in retail rates dispatch SAM 1629#1100
brtietz merged 4 commits into
developfrom
sam_1629_improve_retail_rates_error_handling

Conversation

@brtietz

@brtietz brtietz commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

Throw an error if a user attempts to run retail rates dispatch without provided utility rate data. Update cmod-hybrid so it automatically gives the hybrid vartable to the battery and fuel cell models for dispatch.

Fixes NatLabRockies/SAM#1629, see that PR for test instructions

Pairs with NatLabRockies/SAM#1640, pull that PR for required defaults updates to get this to run.

@brtietz brtietz added this to the SAM Fall 2023 Release milestone Dec 5, 2023
@brtietz brtietz self-assigned this Dec 5, 2023
@brtietz brtietz changed the title Solve crash in retail rates dispatch SAM 1629 WIP: Solve crash in retail rates dispatch SAM 1629 Dec 5, 2023
@brtietz brtietz marked this pull request as draft December 5, 2023 20:19
@brtietz brtietz changed the title WIP: Solve crash in retail rates dispatch SAM 1629 Solve crash in retail rates dispatch SAM 1629 Dec 6, 2023
@brtietz brtietz marked this pull request as ready for review December 6, 2023 17:11
@brtietz brtietz mentioned this pull request Dec 6, 2023
1 task

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PVWatts-Wind-Battery / TPO Host-Developer case runs with retail rate dispatch option and defaults for all other inputs. Simulation takes a while (long pause at 50%) but eventually finishes. The battery only charges and discharges for the first few days of January.

@brtietz brtietz merged commit 0e711b9 into develop Dec 6, 2023
@brtietz brtietz deleted the sam_1629_improve_retail_rates_error_handling branch December 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hybrids Crashes with Utility Rate Dispatch

2 participants