Ssc 755 net to sales#1060
Merged
Merged
Conversation
Collaborator
|
This changes all variables names beginning with "cf_energy_net_" to "cf_energy_sales". For example, These are all output variables, so should only affect PySAM and LK scripts that are using those output variables. I searched all .lk scripts in https://github.com/NREL/SAM/tree/develop/samples and did not find any sample LK scripts that use these variables. |
cpaulgilman
approved these changes
Oct 3, 2023
sjanzou
approved these changes
Oct 4, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and tests appear fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish the "net" to "sales" conversion we started back in the 2021 release. Closes #755, for additional context see #756.
I believe this is an SSC only PR. The only SAM dependencies I could find were in API. My impression is that updates to API are on hold while we work out the export config issues, but if you want me to run the export I can do so.
To test: ensure that the monthly and by TOD period outputs in the FOM financial models are still recording kWh to the grid correctly.