PV subhourly clipping correction#1050
Merged
Merged
Conversation
for no clipping correction
used for subhourly clipping
janinefreeman
requested changes
Sep 13, 2023
janinefreeman
left a comment
Collaborator
There was a problem hiding this comment.
Awesome job implementing a complex model, that needs to carry through to a bunch of different parts of the code! I do have some comments on a few workflow changes (posted in-line). I think they are mostly smaller changes. Happy to talk through any of my thoughts/comments.
| { SSC_OUTPUT, SSC_ARRAY, "inv_total_loss", "Inverter total power loss", "kW", "", "Time Series (Inverter)", "*", "", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "ac_wiring_loss", "AC wiring loss", "kW", "", "Time Series (Inverter)", "*", "", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "ac_gross", "Inverter AC output power", "kW", "", "Time Series (Array)", "*", "", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "clipping_potential", "Clipping potential", "", "", "Time Series (Inverter)", "", "", "" }, |
Collaborator
There was a problem hiding this comment.
These three outputs should be conditionally assigned, only if the subhourly clipping model is enabled, I think. @cpaulgilman - what do you think?
| // annual_ac_gross | ||
| { SSC_OUTPUT, SSC_NUMBER, "annual_ac_inv_eff_loss_percent", "AC inverter efficiency loss", "%", "", "Loss", "", "", "" }, | ||
| { SSC_OUTPUT, SSC_NUMBER, "annual_ac_wiring_loss_percent", "AC wiring loss", "%", "", "Loss", "", "", "" }, | ||
| { SSC_OUTPUT, SSC_NUMBER, "annual_subhourly_clipping_loss_percent", "Subhourly clipping correction loss percent", "%", "", "Loss", "", "", "" }, |
Collaborator
There was a problem hiding this comment.
@cpaulgilman curious on your thoughts if this output should be reported if the subhourly clipping loss model isn't enabled. I don't have a strong opinion one way or the other for the annual results.
janinefreeman
approved these changes
Sep 15, 2023
This was referenced Oct 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Implements Allen method of correcting PV energy output by underprediction of clipping at hourly intervals.
-SDK feature for modifying default correction lookup matrix
-Adds Ineichen clearsky model for all irradiance calculations
-Adds tests of subhourly clipping calculation, Ineichen implementation