Skip to content

Fuel Cell Charge Array and Battery Discharge Array ignore the value in period 6 #1112

@brtietz

Description

@brtietz

Describe the bug
Length checks for optional battery schedule arrays ignore the mismatch between iprofile and size metrics.

To Reproduce
Steps to reproduce the behavior:

  1. Download SAM file from https://sam.nrel.gov/forum/forum-general/4438
  2. See the battery does not discharge to grid in period 6

Expected behavior
Battery should discharge to grid in period 6. Recommend changing lines 119 and 123 in battery_dispatch_manual.cpp to <=

https://github.com/NREL/ssc/blob/75b4b1778d88234149bbb693d72914c2293ee721/shared/lib_battery_dispatch_manual.cpp#L119

Desktop (please complete the following information):

  • Version 2022.11.21, 2023.12.17, maybe others

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions