Describe the bug
Turning on a grid outage with self consumption dispatch causes all of the steps in the grid outage to count towards steps where the system met the load. A fully off-grid system would look like it met load 100% of the time with this system, even if there is critical load unmet.
To Reproduce
Steps to reproduce the behavior:
- Run both cases in the attached SAM file:
grid_outage_self_consumption_test.zip
- Note the grid_outage has higher number of steps where the load is met
- Note the critical load is unmet during the outage.
Expected behavior
While these metrics don't have exactly the same definition (i.e. critical load may be < 100% of load), it seems reasonable that steps in which critical load is unmet shouldn't count towards the self-consumption metrics.
Suggested fix is to add a check for critical load unmet (if there's a grid outage) to https://github.com/NREL/ssc/blob/75b4b1778d88234149bbb693d72914c2293ee721/ssc/cmod_battery.cpp#L2114
Desktop (please complete the following information):
Describe the bug
Turning on a grid outage with self consumption dispatch causes all of the steps in the grid outage to count towards steps where the system met the load. A fully off-grid system would look like it met load 100% of the time with this system, even if there is critical load unmet.
To Reproduce
Steps to reproduce the behavior:
grid_outage_self_consumption_test.zip
Expected behavior
While these metrics don't have exactly the same definition (i.e. critical load may be < 100% of load), it seems reasonable that steps in which critical load is unmet shouldn't count towards the self-consumption metrics.
Suggested fix is to add a check for critical load unmet (if there's a grid outage) to https://github.com/NREL/ssc/blob/75b4b1778d88234149bbb693d72914c2293ee721/ssc/cmod_battery.cpp#L2114
Desktop (please complete the following information):