set random seed for sunrise/sunset estimation#221
Merged
Conversation
Collaborator
Author
|
Tests pass, but linting fails because of bare except clauses in the webinar demo notebook. I'll just take the opportunity to fix those now... |
Collaborator
Author
|
all tests passing and all lint checks successful! 🎉 @cdeline ready review if you don't mind |
cdeline
approved these changes
Feb 13, 2026
cdeline
left a comment
Collaborator
There was a problem hiding this comment.
Mostly linting changes and setting up a random number seed. Tests are passing, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220 and #222
This PR addresses randomness in the sunrise/sunset estimation subroutine. This is a very easy fix. We now expose the random seed argument for the subroutine to the
run_pipelinemethod and set a default value of 42. This causes the same estimate to be generated every time for a given data set (and numpy/cvxpy version). If the user wants the previous random behavior for some reason, this argument can be set toNoneat runtime.Also fixes a minor bug in the Bundt Cake plotting function.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)