Fix REopt API call functions in UI#999
Merged
Merged
Conversation
* Clean up message text
* Update inputs to reflect recent battery dispatch UI changes * Revise UI message text for clarity * Add progress bar
Fix capitalization of "REopt" in UI text and REopt widget. Fix logic in callback so battery size and dispatch inputs are correctly replaced with values for REopt or reset to original values based on user responses to prompts.
sjanzou
approved these changes
Apr 3, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Everything seems to work fine, one question about the PV-Battery/Residential defaults using ReOpt - sizing comes back with 0kW battery size. Should we changed the defaults?
Collaborator
Author
|
@sjanzou I'll check with the team and see if we can come up with a default PV Battery / Residential case that is more cost-effective than PV-only. Note that the NPV for the default case is higher with no storage than with storage because of the cost of the battery, even with the exaggerated fictional rate structure I came up with to get a positive NPV. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update UI battery sizing variables to support kWh or h option for battery duration implemented in #586.
Fix logic in UI callback so REopt API call results are correctly applied based on user responses to prompts.
Fix "REopt" capitalization in UI text and REopt widgets.
Test for PV Battery, Fuel Cell, and PVWatts Battery configurations.
Goes with SAM-private PR.
Fixes #974
Type of change
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.