Puerto Rico Mini Grid Wizard #983
Conversation
…tion::ListAllOutputs
|
Wizard now scales sizing based on number of participants |
brtietz
left a comment
There was a problem hiding this comment.
Scaling factor and outputs look great! My only comment is that I think we ultimately want this to be less location specific prior to releasing it. Happy to discuss further as needed.
| @@ -0,0 +1,331 @@ | |||
| // Puerto Rico Mini Grid macro using PuertoRicoMiniGrid.sam | |||
There was a problem hiding this comment.
Nate had requested we change the name of this (including the file name, I think) since it could be used for any mini grid, not just mini grids in Puerto Rico
| show_page( 'Location and Resource'); | ||
|
|
||
| // Add Puerto Rico weather file(s) to solar resource library | ||
| PuertoRicoWeatherDir = runtimedir() + 'quickstart/puerto_rico_weather'; |
There was a problem hiding this comment.
Not sure how to handle weather files given the above comment, might need more discussion.
cpaulgilman
left a comment
There was a problem hiding this comment.
Load scaling and graph output looks great. Some comments:
- LK script file names for wizards should be consistent with other files in quickstart folder so that all files either use CamelCase, title case or sentence case. In general we use sentence case in SAM, but title case could be appropriate here. Also note getting started guide command uses sentence case:
-
Text in message boxes could use some editing, but deferring to @n8blair who I think was planning to do some editing.
-
If/when we add weather file download capability, I would recommend storing downloaded weather files in
wfdownloaddir()instead ofruntimedir() + 'quickstart/puerto_rico_weather'to improve portability across different SAM versions. This would also make the weather files available for other simulations.
Remove "Puerto Rico" from file names and descriptive text. Edit wizard text for clarity and remove milisleep() pauses after msgbox(). Use consistent case for wizard LK script file names to clean up wizard list on Welcome page.
cpaulgilman
left a comment
There was a problem hiding this comment.
My comments addressed in 7c325e1.
No description provided.