Skip to content

Handle SolarAnywhere data with missing data at end of row#951

Merged
cpaulgilman merged 1 commit into
patchfrom
sa-conversion-macro
Feb 24, 2022
Merged

Handle SolarAnywhere data with missing data at end of row#951
cpaulgilman merged 1 commit into
patchfrom
sa-conversion-macro

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Description

Modify Solar Resource File Converter to handle SolarAnywhere files with empty column at end of row that has a column heading. For example, a file that has a column heading for Albedo at the end of the header row but empty data. Add check for line ending with comma in addition to two consecutive commas.

Fixes #650

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [ x] I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Feb 22, 2022
@cpaulgilman cpaulgilman self-assigned this Feb 22, 2022
@cpaulgilman cpaulgilman merged commit 062a09e into patch Feb 24, 2022
@cpaulgilman cpaulgilman deleted the sa-conversion-macro branch February 24, 2022 23:31
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SolarAnywhere v3.4 with empty albedo column causes Solar Resource File Converter macro to fail

2 participants