Skip to content

Remove crit_load input from PVWatts battery ReOpt calls#945

Merged
mjprilliman merged 1 commit into
patchfrom
pvwatts_reopt_fix
Feb 19, 2022
Merged

Remove crit_load input from PVWatts battery ReOpt calls#945
mjprilliman merged 1 commit into
patchfrom
pvwatts_reopt_fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

Callback error for PVWatts Battery ReOpt invoke function stems from crit_load being defined even though critical load is not defined in PVWatts Battery. Added an assignment check before passing critical load to ReOpt (does not seem to be a required input)

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2021.12.02 Patch 1 milestone Feb 18, 2022
@mjprilliman mjprilliman self-assigned this Feb 18, 2022
@dguittet

Copy link
Copy Markdown
Collaborator

Thanks for getting this! crit_load also needs to be removed from Reopt_size_battery_params in cmod_pvsamv1_eqns.cpp and the Reopt_size_battery_params_doc in cmod_pvsamv1_eqns.h

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Thanks for getting this! crit_load also needs to be removed from Reopt_size_battery_params in cmod_pvsamv1_eqns.cpp and the Reopt_size_battery_params_doc in cmod_pvsamv1_eqns.h

Aah yes sorry I forgot to push the ssc side of this. Working on matching PR now

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Merging as test failures match what is currently in patch branch

@mjprilliman mjprilliman merged commit b71684a into patch Feb 19, 2022
@mjprilliman mjprilliman deleted the pvwatts_reopt_fix branch February 19, 2022 01:06
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants