Remove crit_load input from PVWatts battery ReOpt calls#945
Merged
Conversation
Collaborator
|
Thanks for getting this! |
Collaborator
Author
Aah yes sorry I forgot to push the ssc side of this. Working on matching PR now |
dguittet
approved these changes
Feb 18, 2022
brtietz
approved these changes
Feb 18, 2022
Collaborator
Author
|
Merging as test failures match what is currently in patch branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Callback error for PVWatts Battery ReOpt invoke function stems from crit_load being defined even though critical load is not defined in PVWatts Battery. Added an assignment check before passing critical load to ReOpt (does not seem to be a required input)
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.