Cashflow send excel fixes#936
Merged
Merged
Conversation
…inputs for fuel cell
…e configs without crashing
This was referenced Feb 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #880, #694
O&M Costs
For fuel cell model, disable battery O&M cost inputs when battery not enabled, and display a UI message if those inputs are set to non-zero by a script or opening an old file. This is not enforced in SSC, so SDK users could model battery O&M costs for a system with no batteries.
Set default fuel cell O&M cost by capacity and replacement cost to zero so that battery O&M cost is not included in operating expenses when battery is disabled. This changes the default LCOE for Fuel Cell configurations, so requires running test script.
Fix variable O&M for FOM and BTM with battery configurations.
Cash flow
Fix fuel cell fuel in cash flow: Export SAM cash flow instead of calculating in Excel from heat rate inputs, which works for CSP and other fuel techs, but not for fuel cell.
Show LCOS calculations in cash flow for all battery configs, not just "has_roe()" configs.
Remove has_roe flag from cash flow script because we removed ROE metric in #549
Fix LCOS cash flow equations in Excel.
Fix land lease send to excel for techs with no land area.
Add support for sculpted debt with debt size limit.
Energy Line Items
Add cf_energy_sales to outputs for all financial models.
Change labels on Results page Summary and Losses tab from "energy" to "electricity."
Other
Update urdb_view_rate URL to https://apps.openei.org/IURDB, also fixed in sam-private https://github.com/NREL/SAM-private/commit/af6e99209ef7877496c00a1a39cb786a752b5ab2
UI labels and group names for om_opt_fuel_xxx inputs on Biopower feedstock costs form.
UI group name for Fuel Cell Costs UI form.
Set total_land_area for CSP models for financial model inputs:
Empirical Trough, replace ui_total_land_area with total_land_area
Tower Solar Field, Linear Fresnel Solar Field, Generic CSP Solar Field, LF DSG Solar Field: Add total_land_area input and UI equation to store value of csp.pt.sf.total_land_area
Add total_land_area default for MSPT, DSLF, Generic CSP System, DSGL IPH