Om cost inputs#927
Merged
Merged
Conversation
Set battery O&M cost to zero for fuel cell Change "energy" in metrics, autograph and loss diagram labels to "electricity" Fix operating expenses in cash flow Fix URDB URL in webapis.conf
* Set default battery O&M and replacement cost to zero for fuel cell configs to fix issue with total operating cost including battery costs when battery disabled. This changes the default LCOE for fuel cell configs. * Disable battery O&M cost inputs on fuel cell operating costs page when battery disabled, and add UI text instructions.
sjanzou
previously requested changes
Feb 10, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Battery / Residential configuration has issues with "Electricity to grid net" in cash flow.
Year 1 value = sum("Energy to load from battery (kWh))" value (sign change if compared to no system maybe?):
This was referenced Feb 10, 2022
Closed
brtietz
approved these changes
Feb 11, 2022
Changes have been addressed. Ready to merge this PR so I can include this work in Send to Excel with Equations fixes.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several issues with O&M cost inputs and cash flow outputs:
Remove duplicate cf_om_batt_production_expense battery O&M variables for LCOS calculations.
Remove non-battery O&M costs from cash flow for standalone battery configurations.
For fuel cell model, disable battery O&M cost inputs when battery not enabled, and display a UI message if those inputs are set to non-zero by a script or opening an old file. This is not enforced in SSC, so SDK users could model battery O&M costs for a system with no batteries.
Set default fuel cell O&M cost by capacity and replacement cost to zero so that battery O&M cost is not included in operating expenses when battery is disabled. This changes the default LCOE for Fuel Cell configurations, so requires running test script.
Show LCOS calculations in cash flow for all battery configs, not just "has_roe()" configs.
Remove has_roe flag from cash flow script because we removed ROE metric in Retire PV India Wizard #549
Use consistent SSC group names for O&M outputs "Cash Flow Operating Expenses" (output group names do not affect PySAM). Note that Sale Leaseback uses "Sale Leaseback" for most output variables.
Add battery and fuel cell O&M costs to cash flow calculations in SSC for LPF, AEPF, SLB, and Host Developer financial models.
Add cf_energy_without_battery to all financial models based on implementation in Single Owner.
Fix variable O&M for FOM and BTM with battery configurations.
Remove redundant sales_energy_value.
Use consistent variable labels for cash flow energy terms: Electricity to grid, Electricity from grid, Electricity to grid net
Fixes #901 and #880
Goes with NatLabRockies/ssc#753
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.