Automate ssc differ#921
Conversation
|
@dguittet, looking at the example https://github.com/NREL/SAM/actions/runs/1809701751 and the failing check, what actions should be taken by whoever is running the action? Should this be a pull request failure in the future? |
|
@sjanzou That example is successful. The latest failed due to differences in the test script of the defaults. I'm not sure why that is as this PR has no impact on the test files or those results. |
|
@dguittet I suspect these are due to underlying SSC changes. It seems reasonable that NatLabRockies/ssc#743 would impact the stand alone battery LCOE. |
|
@brtietz That makes sense it's SSC changes. I added upload of the test_results_linux64.csv to Github Actions so we can use it in the test results update process, and will update the test results. |
|
@dguittet Thanks that's a great addition! The bad news is that the CI chooses pass/fail based on the comparison with the Windows test results, the linux results are info only. I could make a PR with the new Windows results if that's helpful. |
|
@brtietz It would be great to have a Windows test eventually! But it doesn't have to be right now unless you happen to already have it on your list. |
|
@dguittet , did these changes get merged into develop, too? |
|
@sjanzou Thanks for the reminder! |
Description
Automating the SSC Variable and SAM default differ to run in Github Actions
Requires an easy way to query and download the previous SAM version, this is done by adding the download paths to the Github Releases: such as for the 2021.12.02.r0.ssc.267 release here: https://github.com/NREL/SAM/releases/tag/2021.12.02.r0.ssc.267
Steps to Use:
Here's an example Github Action run: https://github.com/NREL/SAM/actions/runs/1809701751
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.