Skip to content

Update Wind Turbine Characteristics equation behavior#897

Merged
mjprilliman merged 5 commits into
patchfrom
SAM_877
Feb 11, 2022
Merged

Update Wind Turbine Characteristics equation behavior#897
mjprilliman merged 5 commits into
patchfrom
SAM_877

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

Update elevation used in calculation of user-defined wind turbine power curves. Use weather file elevation + hub height for wind resource file option, User defined elevation + hub height for Weibull option, 0? for wind resource probability table.
-Add UI warnings when equation does not solve for power curves, reset power curve plot

Fixes #877

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem described in #877.

@mjprilliman mjprilliman merged commit 7e25297 into patch Feb 11, 2022
@mjprilliman mjprilliman deleted the SAM_877 branch February 11, 2022 18:24
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug wind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wind "Define Turbine Design Characteristics" option causes UI callback error

2 participants