Skip to content

Simplify utility rate defaults for FOM configurations#790

Closed
mjprilliman wants to merge 3 commits into
developfrom
fom_utilityrate_updates
Closed

Simplify utility rate defaults for FOM configurations#790
mjprilliman wants to merge 3 commits into
developfrom
fom_utilityrate_updates

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

Some utility rate pages for FOM configs designed to provide a option for costs of parasitic loads had fixed monthly charges or demand charges. The default for these FOM configs should have a single buy rate as the default as this will be the use case most often.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2021 Release milestone Nov 19, 2021
@mjprilliman mjprilliman self-assigned this Nov 19, 2021
@mjprilliman

Copy link
Copy Markdown
Collaborator Author

On the last commit, there is a recurring issue where assigning a 0 value to a variable assigns a very small number (e-400) rather than true 0. In the past I've resolved this by assigning 0.0 rather than 0 in the Defaults Manager.

image

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

I don't believe this should be merged as the proper utility rate updates were made in full in #786. Will close this PR.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Agreed.

@mjprilliman mjprilliman deleted the fom_utilityrate_updates branch December 9, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants