Fix NSRDB download location name check#761
Merged
Merged
Conversation
* This fix should allow location name entered as any string, a city/state pair separated by a comma, or a lat/lon pair separated by a comma followed by a space, comma with no space, or space with no comma.
brtietz
approved these changes
Nov 12, 2021
Collaborator
Author
|
The error message about "required 'email' parameter" should only happen when you test on a non-NREL version of SAM because the email value comes from the registration process. We can double check this when we build a Beta version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #710
This fix should allow location name entered as any string, a city/state pair separated by a comma, or a lat/lon pair separated by a comma followed by a space, comma with no space, or space with no comma.