Fixed battery sizing equations to reference computed bank power rather than desired bank power and capacity#560
Closed
mjprilliman wants to merge 3 commits into
Closed
Fixed battery sizing equations to reference computed bank power rather than desired bank power and capacity#560mjprilliman wants to merge 3 commits into
mjprilliman wants to merge 3 commits into
Conversation
than desired bank power
cpaulgilman
approved these changes
Mar 12, 2021
Collaborator
|
Here are a set of diagrams and screenshots showing how the calculations are expected to work: |
Collaborator
|
@dguittet If you have a chance, could you review this pull request? I'd like to have this merged into patch before I start my work reorganizing the battery UI inputs. Thanks! |
dguittet
approved these changes
Mar 19, 2021
Collaborator
|
Looks good! Sorry for the delay. |
Collaborator
Author
|
See #580 for merged changes, this branch has messed up root branches. Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Sets correct battery bank capacity and bank power basis for maximum discharge and charge calculations on both AC and DC connected systems for AC and DC battery sizing options
-Changes * dc_ac efficiency to / ac_dc efficiency for Bank power maximum charge AC calculations when AC connected