First batch of nlr.gov api changes#2157
Conversation
|
Visual inspection of changes look fine, but after fighting substantially with my build I can't get it working to test it. I'm not sure if it's interacting with or-tools settings (although I did try deleting the build folder and running an old cmake command to no avail)- will try again when other resources are online for help 😝 |
https://github.com/NatLabRockies/SAM/wiki/Windows-Build-Instructions is up to date, what other resources are you waiting for? I personally have had some issues with that cmake command, and transitioned the |
|
You being available to jump on a call to debug my build was exactly the "resource" I had in mind 😄 I didn't mean to imply incompleteness in documentation, I believe this is user error 🤣 |
mjprilliman
left a comment
There was a problem hiding this comment.
All the API's I could think to check work. Still some NREL in various places, but the high priority links all appear to be good.
… a few other PR comments
There was a problem hiding this comment.
Finally got everything building correctly (thanks @mjprilliman and @brtietz ) and looks good here. Tested user registration, welcome window, NSRDB download, and wind toolkit download.
Pull Request Template
Description
Update nrel.gov to nlr.gov in the SAM repo
Corresponding branches and PRs:
Patch for lk, wex, ssc.
2156_pt1_nrel_dot_gov for sam-private
cmake command given non-ortools build:
Old batch CMakeLists.txt:
CMakeLists_patch.txt
Unit Test Impact:
No changes for others
Checklist