Conversation
… first check if initialized. If not, initialize
cpaulgilman
approved these changes
Jul 1, 2025
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks for the fix!
sjanzou
approved these changes
Jul 2, 2025
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the update and the details of all the bugs fixed in the pull request!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#2013 reports a bug in which creating new cases from parametric runs leads to a crash if the parametric runs haven't actually been simulated.
@cpaulgilman 's steps to reproduce:
I note that the crash also occurs if one chooses "Show inputs". The cause of this issue, and the solution, are the same as for the original reported issue.
This bug is caused by attempting to read uninitialized data.
This PR solves this problem by checking for initialization before this read, and if uninitialized, initializes.
Fixes #2013
Corresponding branches and PRs:
This is a SAM-only change.
Unit Test Impact:
No unit test impact.
Checklist