Skip to content

Fix order issue #1906 and do not allow free form combo box inputs#1907

Merged
sjanzou merged 3 commits into
developfrom
SAM_1906
Nov 13, 2024
Merged

Fix order issue #1906 and do not allow free form combo box inputs#1907
sjanzou merged 3 commits into
developfrom
SAM_1906

Conversation

@sjanzou

@sjanzou sjanzou commented Nov 12, 2024

Copy link
Copy Markdown
Collaborator

Please test the Detailed PV DC and AC losses and any use of the wxUILossAdjustmentCtrl and anywhere the AFDataLifetimeMatrixDialog and AFDataLifetimeArrayDialog are used - e.g. AFDataLifetimeMatrixDialog

@sjanzou sjanzou self-assigned this Nov 12, 2024
@sjanzou sjanzou linked an issue Nov 12, 2024 that may be closed by this pull request

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! This corrected the behavior such that it's driven by default values rather than anything else. As per widgets.cpp 2635 any value that isn't easily divisible by the analysis period defaults to subhourly.

I've added some suggested defaults changes to get everything on single value, but I'm open to other approaches (such as annual to match the mode in the UI form).

@cpaulgilman

Copy link
Copy Markdown
Collaborator

I've added some suggested defaults changes to get everything on single value, but I'm open to other approaches (such as annual to match the mode in the UI form).

The benefit of using single value as a default is one less default that is a time series array. Hourly would also be a reasonable default because it matches the default simulation time step. I lean sligthly toward single value to help reduce defaults maintenance headaches. If we do go the single value route, we should make the default change for all configurations.

@sjanzou sjanzou merged commit 1f7ca1f into develop Nov 13, 2024
@sjanzou sjanzou deleted the SAM_1906 branch November 13, 2024 07:04
@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 10, 2024
@cpaulgilman cpaulgilman added bug added to release notes PR and/or issue has been added to release notes for a public release labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust Losses UI forms list order is backwards from IDE

4 participants