Skip to content

Adjust widget for wave and tidal technologies#1885

Merged
mjprilliman merged 6 commits into
developfrom
wave-tidal-adjust
Oct 28, 2024
Merged

Adjust widget for wave and tidal technologies#1885
mjprilliman merged 6 commits into
developfrom
wave-tidal-adjust

Conversation

@mjprilliman

@mjprilliman mjprilliman commented Oct 23, 2024

Copy link
Copy Markdown
Collaborator

Description

-Adds adjust widget on shared losses page for wave, wave-battery and tidal (lifetime mode only accessible for wave-battery)
-Widget checks for timeseries data (as opposed to frequency matrix data), disables if timeseries resource data is not being used
-Adds Three Hour data to timeseries loss dropdown, ssc checks for misalignment of three hour data with resource data for all technologies same as hourly and subhourly data

Fixes #1247

Goes with NatLabRockies/ssc#1225

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I set Marine Wave Three Hourly loss and run a simulation, the next time I open the adjust widget, the time series mode reverts to Subhourly mode. For other technologies, the time series mode opens in the same state as the last time I closed it.

@cpaulgilman

cpaulgilman commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator

Help revision for Marine Energy Wave and Marine Energy Tidal chapters:

Losses

image

Edit Losses Window

image

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

If I set Marine Wave Three Hourly loss and run a simulation, the next time I open the adjust widget, the time series mode reverts to Subhourly mode. For other technologies, the time series mode opens in the same state as the last time I closed it.

Thanks for catching that Paul. I think my recent commit fixes this issue. The help documentation looks good.

@mjprilliman mjprilliman merged commit df74232 into develop Oct 28, 2024
@mjprilliman mjprilliman deleted the wave-tidal-adjust branch October 28, 2024 14:43
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release enhancement marine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loss Factor adjustment widget in wave, wave-battery, tidal models

2 participants