Adjust widget for wave and tidal technologies#1885
Merged
Conversation
cpaulgilman
requested changes
Oct 25, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
If I set Marine Wave Three Hourly loss and run a simulation, the next time I open the adjust widget, the time series mode reverts to Subhourly mode. For other technologies, the time series mode opens in the same state as the last time I closed it.
Collaborator
Collaborator
Author
Thanks for catching that Paul. I think my recent commit fixes this issue. The help documentation looks good. |
cpaulgilman
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
-Adds adjust widget on shared losses page for wave, wave-battery and tidal (lifetime mode only accessible for wave-battery)
-Widget checks for timeseries data (as opposed to frequency matrix data), disables if timeseries resource data is not being used
-Adds Three Hour data to timeseries loss dropdown, ssc checks for misalignment of three hour data with resource data for all technologies same as hourly and subhourly data
Fixes #1247
Goes with NatLabRockies/ssc#1225
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.