Skip to content

Update pysam files for CSP#1804

Merged
dguittet merged 2 commits into
developfrom
update_pysam
Jul 15, 2024
Merged

Update pysam files for CSP#1804
dguittet merged 2 commits into
developfrom
update_pysam

Conversation

@dguittet

@dguittet dguittet commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

Updating CSP PySAM files for a custom PySAM release using the develop branch of SSC

@dguittet dguittet requested review from qualand and taylorbrown75 July 8, 2024 20:37
@dguittet dguittet changed the base branch from patch to develop July 8, 2024 20:38
@dguittet dguittet marked this pull request as ready for review July 8, 2024 20:38
@dguittet

dguittet commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator Author

@qualand I'm seeing some deleted PySAM modules: TroughPhysicalCspSolver and PhysicalTroughProcessHeat

Can you confirm these changes (and the others in this PR) are correct?

@qualand

qualand commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

@taylorbrown75 can you confirm these changes?

@qualand I'm seeing some deleted PySAM modules: TroughPhysicalCspSolver and PhysicalTroughProcessHeat

Can you confirm these changes (and the others in this PR) are correct?

@taylorbrown75

Copy link
Copy Markdown
Collaborator

Both modules are retired, they were removed intentionally.

@dguittet dguittet merged commit 5cd444c into develop Jul 15, 2024
@dguittet dguittet deleted the update_pysam branch July 15, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants