Skip to content

Address hybrid SAM lk scripting issues in #1636#1800

Merged
sjanzou merged 2 commits into
patchfrom
SAM_1636
Jun 20, 2024
Merged

Address hybrid SAM lk scripting issues in #1636#1800
sjanzou merged 2 commits into
patchfrom
SAM_1636

Conversation

@sjanzou

@sjanzou sjanzou commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

To test:

  1. check out SAM_1636 branch of SAM and patch branches of other repos

  2. open the project file and lk script file in the zip archive
    SAM_1636.zip

  3. run the script and select "tilt" from input variable dialog in the hybrid
    image
    and non-hybrid configurations
    image

Expect results - hybrid configuration
image

Expect results - non-hybrid configuration
image

@sjanzou sjanzou self-assigned this Jun 19, 2024
@sjanzou sjanzou linked an issue Jun 19, 2024 that may be closed by this pull request
@janinefreeman janinefreeman removed their request for review June 19, 2024 16:30

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for hybrids variables, and thanks for introducing me to the select_inputs() function. Even an old dog can learn new tricks.

@sjanzou sjanzou merged commit e7e16f4 into patch Jun 20, 2024
@sjanzou sjanzou deleted the SAM_1636 branch June 20, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scripting doesn't work for Hybrid Cases

2 participants