Conversation
cpaulgilman
approved these changes
Apr 18, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good -- I'm not seeing OLE Automation errors for the PV Battery / Commercial config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved error handling when setting named range values in Excel workbooks with equations
To test, run the test file
PV_Batt_Com.zip
in the current release and receive the OLE errors
Build SAMOS with the patch branches of lk, wex, and ssc and the SAM_1563 branch of SAM and open and run the the file and "Send to Excel with equations" and receive no OLE errors and metrics that match between the Excel workbook with equations and SAM
