Help updates for SAM 2023.12.17 r1#1725
Merged
Merged
Conversation
Clean up window reference topics. Detailed PV time series results, also note lat/long/elev/tz pass through from weather file Fix PV land area and GCR descriptions. Revise Solar Resource topic Electric Load subhourly weather file available via solar resource Advanced Donwload option.
brtietz
approved these changes
Mar 1, 2024
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for updating! I have a few nitpicks and found one typo, but still happy to approve.
| <p class="p_VariableName" style="page-break-inside: avoid; page-break-after: avoid;"><span class="f_VariableName">Ground coverage ratio (GCR)</span></p> | ||
| <p class="p_VariableDescription"><span class="f_VariableDescription">The ratio of the photovoltaic array area to the total ground area. For an array configured in rows of modules, the GCR is the length of the side of one row divided by the distance between the bottom of one row and the bottom of its neighboring row. An array with a low ground coverage ratio (closer to zero) has rows spaced further apart than an array with a high ground coverage ratio (closer to 1).</span></p> | ||
| <p class="p_VariableDescription"><span class="f_VariableDescription">The ratio of the photovoltaic array area to the ground area occupied by the array. For an array configured in rows of modules, the GCR is the length of the side of one row divided by the distance between the bottom of one row and the bottom of its neighboring row. Increasing the GCR dereases the spacing between rows.</span></p> |
Collaborator
There was a problem hiding this comment.
Typo: "decreases"
Is it worth mentioning that tilt doesn't affect GRC? I've gotten that question twice in the last few weeks.
| <p class="p_VariableName" style="page-break-inside: avoid; page-break-after: avoid;"><span class="f_VariableName">Land area per system capacity</span></p> | ||
| <p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWe</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity.</span></p> | ||
| <p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWac</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity. Typical values range between 5 and 10 acres/MWac.</span></p> |
Collaborator
There was a problem hiding this comment.
I might recommend knocking the lower limit down to 4. The latest report from the reV team has 4.3 acres/MWac (assuming an ILR of 1.34) https://www.nrel.gov/docs/fy24osti/87843.pdf (pg 7)
| <p class="p_VariableName" style="page-break-inside: avoid; page-break-after: avoid;"><span class="f_VariableName">Land area per system capacity</span></p> | ||
| <p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWe</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity.</span></p> | ||
| <p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWac</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity. Typical values range between 5 and 10 acres/MWac.</span></p> |
Collaborator
There was a problem hiding this comment.
If we change detailed PV based on my comment above, this also needs to change.
sjanzou
approved these changes
Mar 3, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good for patch 1 and release candidate.
A few comments from Brian that we can update after testing release candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up window reference topics.
Detailed PV time series results, also note lat/long/elev/tz pass through from weather file
Fix PV land area and GCR descriptions.
Revise Solar Resource topic
Electric Load subhourly weather file available via solar resource Advanced Donwload option.