Skip to content

Add support for MSG V1.0.0 NSRDB API endpoint#1720

Merged
cpaulgilman merged 1 commit into
patchfrom
nsrdb-msg-v1-0-0-updates
Feb 29, 2024
Merged

Add support for MSG V1.0.0 NSRDB API endpoint#1720
cpaulgilman merged 1 commit into
patchfrom
nsrdb-msg-v1-0-0-updates

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

TMY data for Europe and Africa is now available through NSRDB MSG V1.0.0: https://developer.nrel.gov/docs/solar/nsrdb/nsrdb-msg-v1-0-0-tmy-download/

This adds support for downloading this data from the Solar Resource input page.

Fixes #1719

Goes with NatLabRockies/ssc#1140

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
image

and
image

The 15 min check box will be added in #1534 for patch 2

@cpaulgilman cpaulgilman merged commit 59eae61 into patch Feb 29, 2024
@cpaulgilman cpaulgilman deleted the nsrdb-msg-v1-0-0-updates branch February 29, 2024 16:20
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Solar Resource page downloads for new NSRDB msg-v1-0-0-tmy endpoint

2 participants