Conversation
Need support for SSC_DATA_ARRAY and SSC_TABLE types for all supported hybrid generation.
cpaulgilman
approved these changes
Feb 28, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good -- inputs are grouped by technology in JSON, and SSC test passes.
This is different from PySAM JSON, and from JSON generated by Shift-F5 (save case inputs as JSON) and Ctril-F7 (save case inputs as JSON for SSC). Seems like we should consolidate these different save-inputs-as-JSON methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with ssc pull request 1139
Check out TEST_F(CmodHybridTest, CodeGeneratorPVWattsv8WindBatterySingleOwner) test in ssc that uses PVWatts_Wind_Battery_Hybrid_Single_Owner.json file generated from SAM.