@mjprilliman Is there supposed to be an option to choose time series or JPD for the ME Wave model? Help describes the option, but I don't see it on the Wave Resource page:

Also, when I click Create JPD from time series weather file(s) for a folder with 1979-2010 time series data that I just downloaded, I get a UI callback error:

Could not evaluate callback function:jpd_multiyear->on_change
[60]: error in call to 'value()': variable 'wave_resource_filename' does not exist in this context[51]: eval error in statement list
[49]: eval error in statement list
[46]: eval error in statement list
[46]: error inside function call

@mjprilliman Is there supposed to be an option to choose time series or JPD for the ME Wave model? Help describes the option, but I don't see it on the Wave Resource page:

Also, when I click Create JPD from time series weather file(s) for a folder with 1979-2010 time series data that I just downloaded, I get a UI callback error:

Could not evaluate callback function:jpd_multiyear->on_change
[60]: error in call to 'value()': variable 'wave_resource_filename' does not exist in this context[51]: eval error in statement list
[49]: eval error in statement list
[46]: eval error in statement list
[46]: error inside function call

Paul, no for the Single Owner model there is only the time series option due to the requirement for a time series in the cash flow. This PR is to fix some issues with JPD file generation and to make the header data for wave and tidal resource data more dynamic. I will look into the bug you've posted and schedule a meeting to discuss the weather file handling.

@mjprilliman I'm testing this with the hourly file you fixed from this discussion on the SAM Forum. I put the file in my SAM Downloaded Weather files folder, but am not seeing it in the library, even after clicking Refresh library and reloading the input page. The file does appear in the library in SAM 2023.12.17, but not in my build from this me-wave-file-reader branch.

@mjprilliman I'm testing this with the hourly file you fixed from this discussion on the SAM Forum. I put the file in my SAM Downloaded Weather files folder, but am not seeing it in the library, even after clicking Refresh library and reloading the input page. The file does appear in the library in SAM 2023.12.17, but not in my build from this me-wave-file-reader branch.

Did you have the ssc branch checked out as well?

Did you have the ssc branch checked out as well?

Yes, this is for a clean build from SAM/me-wave-file-reader and ssc/me-wave-file-reader.

Did you have the ssc branch checked out as well?

Yes, this is for a clean build from SAM/me-wave-file-reader and ssc/me-wave-file-reader.

Can you pull ssc for the most recent commit and try again? I downloaded the file directly from email and was able to get it into the library locally just now.

In the UI callback for the Marine Wave Resource Time Series form, I'm seeing rescanlibrary('wave_ts') and rescanlibrary( 'wave' ). I think the name of the wave library is location_ts, not wave_ts or wave. I tried changing those, but that didn't fix it, so I'm not sure what the problem is.

Also, in this snippet for the Refresh library button there is refresh('wave_resource_matrix'), but wave_resource_matrix is not an input on that form:

@mjprilliman Here's some additional information: I have several valid wave resource files in my <user>/SAM Downloaded Weather Files folder. If my list of wave data folders is empty, then the files do not appear in the library:

However, if I add <user>/SAM Downloaded Weather Files to my list of wave data folders, then the files appear in the library:

The library should populate from the folder shown in "Folder for Downloaded Wave Data Files" and the folders listed under "Wave Data File Folders" in the Wave Resource Data Settings widget.