More manually check whether inverter needs to be updated in version#1652
Merged
Conversation
Collaborator
It turns out the default inverters from SAM 2022.11.21 are still in the library after all (long story about processing CEC inverter data that I won't tell here). I decided to keep the new default inverters based on latest market reports about manufacturer share of market. |
cpaulgilman
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade script
Pull Request Template
Description
-Don't prompt user to choose new inverter if inverter is still in library
@cpaulgilman which inverters defaults from old version are no longer in the library? I couldn't seem to find them to test if they are still being caught with this new approach (couldn't get ?@ check to work).
Fixes #1647
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.