Skip to content

More manually check whether inverter needs to be updated in version#1652

Merged
janinefreeman merged 2 commits into
developfrom
inv-upgrade-check
Dec 9, 2023
Merged

More manually check whether inverter needs to be updated in version#1652
janinefreeman merged 2 commits into
developfrom
inv-upgrade-check

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

upgrade script

Pull Request Template

Description

-Don't prompt user to choose new inverter if inverter is still in library
@cpaulgilman which inverters defaults from old version are no longer in the library? I couldn't seem to find them to test if they are still being caught with this new approach (couldn't get ?@ check to work).

Fixes #1647

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the dev bug Internal bug that should not be included in release notes label Dec 8, 2023
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Dec 8, 2023
@mjprilliman mjprilliman self-assigned this Dec 8, 2023
@cpaulgilman

Copy link
Copy Markdown
Collaborator

@cpaulgilman which inverters defaults from old version are no longer in the library? I couldn't seem to find them to test if they are still being caught with this new approach (couldn't get ?@ check to work).

It turns out the default inverters from SAM 2022.11.21 are still in the library after all (long story about processing CEC inverter data that I won't tell here). I decided to keep the new default inverters based on latest market reports about manufacturer share of market.

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@janinefreeman janinefreeman merged commit 8370187 into develop Dec 9, 2023
@janinefreeman janinefreeman deleted the inv-upgrade-check branch December 9, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev bug Internal bug that should not be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inverter CEC upgrade script trips on existing inverters

4 participants