Skip to content

Fix issue #1618#1646

Merged
sjanzou merged 3 commits into
developfrom
SAM_1630
Dec 10, 2023
Merged

Fix issue #1618#1646
sjanzou merged 3 commits into
developfrom
SAM_1630

Conversation

@sjanzou

@sjanzou sjanzou commented Dec 8, 2023

Copy link
Copy Markdown
Collaborator

Would like to have additional functionality in inputs browser to better compare across all technologies including hybrids...

Test project file
SAM_1630.sam.zip

sjanzou and others added 2 commits December 8, 2023 03:41
Would like to have additional functionality in inputs browser to better compare across all technologies including hybrids
@sjanzou sjanzou self-assigned this Dec 8, 2023
@sjanzou sjanzou linked an issue Dec 8, 2023 that may be closed by this pull request

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the first cmod in the config that gets printed before the ':'? That's a little confusing for wave as wave_file_reader comes before mhk_wave, but that can be discussed more later. The example file works for me.

@janinefreeman janinefreeman added this to the SAM Fall 2023 Release milestone Dec 8, 2023

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@tyneises tyneises left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some remaining problems in #1630

@sjanzou sjanzou merged commit 1164931 into develop Dec 10, 2023
@sjanzou sjanzou deleted the SAM_1630 branch December 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inputs Browsers not working for some technology models

5 participants