Conversation
Note "Change model..." between hybrids and non-hybrids does not preserve values
cpaulgilman
approved these changes
Dec 6, 2023
brtietz
reviewed
Dec 6, 2023
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Works with non-hybrids as Paul indicates on Windows. Test results suggest a Mac error with test_script_ow.lk
Does not work from hybrid to hybrid. To test:
- Create a PVWatts-Wind-Battery case
- Increase the battery size
- Use change model to change to PVWatts-Fuel Cell-Wind-Battery
- Battery size has reverted to the defaults.
What is the expected behavior for hybrid to hybrid model changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that "Change model..." does not preserve changes between hybrid and non-hybrid configurations.