Skip to content

Update label checks, lowercase handling#1637

Merged
sjanzou merged 2 commits into
developfrom
sam-1627
Dec 6, 2023
Merged

Update label checks, lowercase handling#1637
sjanzou merged 2 commits into
developfrom
sam-1627

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Update label name checking to avoid skipping "Photovoltaic" prepend for length check
-Remove lowercasing of first word after prepend, causes issues with CEC, POA, annual Energy, etc.

Fixes #1627

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the dev bug Internal bug that should not be included in release notes label Dec 5, 2023
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Dec 5, 2023
@mjprilliman mjprilliman self-assigned this Dec 5, 2023

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels in cash flow are correct:

image

Prepending of hybrid technology name looks good for "annual energy" variables, but some capitalization inconsistency is left over from older naming convention:

image

Capitalization of acronyms looks good:

image

image

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this!

@sjanzou sjanzou merged commit 4d4d9ae into develop Dec 6, 2023
@sjanzou sjanzou deleted the sam-1627 branch December 6, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev bug Internal bug that should not be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Photovoltaic" label missing in Hybrid Cashflows on energy line

3 participants